Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix theme validation and theme check workflow errors #8198

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Fix theme validation and theme check workflow errors #8198

merged 5 commits into from
Oct 11, 2024

Conversation

madhusudhand
Copy link
Member

@madhusudhand madhusudhand commented Sep 24, 2024 •
edited
Loading

Changes proposed in this Pull Request:

Theme Validation workflow

  1. This PR includes style.css changes as PR paths to validate. Without it, the validation workflow doesn't not validate themes with style.css only changes.

  2. Also fixes minor issue where args is empty array.

 file:///home/runner/work/themes/themes/theme-utils.mjs:148
			while ( args[ 0 ].startsWith( '--' ) ) {
			                  ^

TypeError: Cannot read properties of undefined (reading 'startsWith')

Theme Check workflow

It fixes the following issue with theme check workflow (also simplifies the directory finding logic)

Run IFS=',' read -ra FOLDERS <<< ".github"
Processing theme folder: .github
ℹ Starting 'wp theme activate .github' on the cli container. 

Error: The '.github' theme could not be found.
✖ Command failed with exit code 1
Command failed with exit code 1
Error: Process completed with exit code 1.

Testing instructions:

A test PR #8199 should run successfully.
Please add any other scenarios to validate.

@madhusudhand madhusudhand mentioned this pull request Sep 24, 2024
Draft
@madhusudhand madhusudhand changed the title Theme validation: add style.css to validation paths Fix theme validation and theme check workflow errors Sep 24, 2024
@madhusudhand madhusudhand force-pushed the fix-theme-workflow branch 2 times, most recently from c6c5acf to a44739e Compare September 24, 2024 11:37
matiasbenedetto
matiasbenedetto approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@matiasbenedetto matiasbenedetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@matiasbenedetto matiasbenedetto mentioned this pull request Sep 24, 2024
Merged
@madhusudhand madhusudhand merged commit 2a5f65e into trunk Oct 11, 2024
2 checks passed
@madhusudhand madhusudhand deleted the fix-theme-workflow branch October 11, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcanales vcanales vcanales left review comments

@matiasbenedetto matiasbenedetto matiasbenedetto approved these changes

Assignees

@madhusudhand madhusudhand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madhusudhand @vcanales @matiasbenedetto